refactor: cloud-sysvmadm script by shwstppr · Pull Request #9200 · apache/cloudstack

shwstppr · 2024-06-10T12:42:10Z

Description

Fixes: #9000

Fixes script, mainly the queryAsyncJobResult response parsing
Indentations
Use uuid instead of database id

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

root@pr8601-t6928-kvm-ubuntu22-mgmt1:~# /usr/bin/cloudstack-sysvmadm -p pssword -s
mysql: [Warning] Using a password on the command line interface can be insecure.
mysql: [Warning] Using a password on the command line interface can be insecure.
mysql: [Warning] Using a password on the command line interface can be insecure.

Stopping and starting 1 secondary storage vm(s)...
Done stopping and starting secondary storage vm(s)

Stopping and starting 1 console proxy vm(s)...
Done stopping and starting console proxy vm(s) .

codecov · 2024-06-10T13:27:45Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.07%. Comparing base (54c8b71) to head (96e7c36).
Report is 51 commits behind head on 4.19.

Additional details and impacted files

@@            Coverage Diff             @@
##               4.19    #9200    +/-   ##
==========================================
  Coverage     15.07%   15.07%            
- Complexity    11169    11171     +2     
==========================================
  Files          5405     5405            
  Lines        472677   472677            
  Branches      60049    59608   -441     
==========================================
+ Hits          71269    71272     +3     
+ Misses       393479   393477     -2     
+ Partials       7929     7928     -1

Flag	Coverage Δ
uitests	`4.27% <ø> (ø)`
unittests	`15.79% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

shwstppr · 2024-06-12T09:19:25Z

@blueorangutan package

blueorangutan · 2024-06-12T09:20:03Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-06-12T11:06:32Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9892

DaanHoogland

clgtm, mostly cleanup

DaanHoogland · 2024-06-18T08:54:52Z

@blueorangutan test

blueorangutan · 2024-06-18T08:56:05Z

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2024-06-19T00:01:17Z

[SF] Trillian test result (tid-10486)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 52697 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9200-t10486-kvm-centos7.zip
Smoke tests completed. 128 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_invalid_upgrade_kubernetes_cluster	`Failure`	246.88	test_kubernetes_clusters.py
test_02_trigger_shutdown	`Failure`	341.64	test_safe_shutdown.py
test_05_vmschedule_test_e2e	`Failure`	361.84	test_vm_schedule.py

yadvr

LGTM - didn't test it though, not even sure who uses this. I know we may have this logged in release/upgrade notes.

Fixes apache#9000 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

DaanHoogland · 2024-07-11T12:26:08Z

@blueorangutan package

blueorangutan · 2024-07-11T12:28:03Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-07-11T13:31:41Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10326

DaanHoogland · 2024-07-12T07:41:58Z

@blueorangutan test

blueorangutan · 2024-07-12T07:44:06Z

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

shwstppr · 2024-07-12T08:34:33Z

I don't see this script being called in the code anywhere so not sure if smoke tests would find anything

DaanHoogland · 2024-07-12T08:37:29Z

I don't see this script being called in the code anywhere so not sure if smoke tests would find anything

sorry, blind execution

blueorangutan · 2024-07-12T21:28:39Z

[SF] Trillian test result (tid-10810)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 47918 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9200-t10810-kvm-centos7.zip
Smoke tests completed. 131 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_03_secured_to_nonsecured_vm_migration	`Error`	3966.88	test_vm_life_cycle.py
test_09_expunge_vm	`Failure`	427.61	test_vm_life_cycle.py

yadvr · 2024-09-04T06:41:25Z

@blueorangutan package

blueorangutan · 2024-09-04T06:42:04Z

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-09-04T08:03:53Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 10944

DaanHoogland · 2024-09-04T12:32:17Z

@blueorangutan package

blueorangutan · 2024-09-04T12:34:03Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-09-04T13:36:16Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10961

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr marked this pull request as ready for review June 12, 2024 09:19

DaanHoogland linked an issue Jun 18, 2024 that may be closed by this pull request

cloudstack-sysvmadm - /etc/rc.d/init.d/functions: No such file or directory #9000

Closed

DaanHoogland approved these changes Jun 18, 2024

View reviewed changes

DaanHoogland added the status:needs-testing label Jun 18, 2024

yadvr approved these changes Jun 24, 2024

View reviewed changes

shwstppr added 3 commits July 11, 2024 05:25

refactor: cloud-sysvmadm script

8e89e85

Fixes apache#9000 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

fix

3849403

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

use uuid, fix queryjobresult

489ca01

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

DaanHoogland force-pushed the refactor-cloud-sysvmadm branch from a85cf83 to 489ca01 Compare July 11, 2024 12:25

Merge branch '4.19' into refactor-cloud-sysvmadm

96e7c36

yadvr approved these changes Sep 4, 2024

View reviewed changes

yadvr added this to the 4.19.2.0 milestone Sep 4, 2024

DaanHoogland mentioned this pull request Sep 4, 2024

cloudstack-sysvmadm - /etc/rc.d/init.d/functions: No such file or directory #9000

Closed

DaanHoogland merged commit cfbdeba into apache:4.19 Sep 18, 2024

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Sep 23, 2024

refactor: cloud-sysvmadm script (apache#9200)

611dba8

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

DaanHoogland deleted the refactor-cloud-sysvmadm branch September 27, 2024 13:45

DaanHoogland removed the status:needs-testing label Jan 31, 2025

Conversation

shwstppr commented Jun 10, 2024 • edited by DaanHoogland Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented Jun 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

shwstppr commented Jun 12, 2024

Uh oh!

blueorangutan commented Jun 12, 2024

Uh oh!

blueorangutan commented Jun 12, 2024

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Jun 18, 2024

Uh oh!

blueorangutan commented Jun 18, 2024

Uh oh!

blueorangutan commented Jun 19, 2024

Uh oh!

yadvr left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Jul 11, 2024

Uh oh!

blueorangutan commented Jul 11, 2024

Uh oh!

blueorangutan commented Jul 11, 2024

Uh oh!

DaanHoogland commented Jul 12, 2024

Uh oh!

blueorangutan commented Jul 12, 2024

Uh oh!

shwstppr commented Jul 12, 2024

Uh oh!

DaanHoogland commented Jul 12, 2024

Uh oh!

blueorangutan commented Jul 12, 2024

Uh oh!

yadvr commented Sep 4, 2024

Uh oh!

blueorangutan commented Sep 4, 2024

Uh oh!

blueorangutan commented Sep 4, 2024

Uh oh!

DaanHoogland commented Sep 4, 2024

Uh oh!

blueorangutan commented Sep 4, 2024

Uh oh!

blueorangutan commented Sep 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

shwstppr commented Jun 10, 2024 •

edited by DaanHoogland

Loading

codecov bot commented Jun 10, 2024 •

edited

Loading